Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove with-cookie-auth #11865

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Remove with-cookie-auth #11865

merged 1 commit into from
Apr 14, 2020

Conversation

lfades
Copy link
Member

@lfades lfades commented Apr 13, 2020

This example is something we don't and can't recommend to the community as it doesn't have any kind of security measures implemented, we currently have better examples for this so the readme has been updated to recommend those instead.

@lfades lfades requested a review from Timer as a code owner April 13, 2020 23:23
@ijjk
Copy link
Member

ijjk commented Apr 13, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary lfades/next.js examples/remove-with-cookie-auth Change
buildDuration 10.9s 11.2s ⚠️ +311ms
nodeModulesSize 55.5 MB 55.5 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary lfades/next.js examples/remove-with-cookie-auth Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..a4ac.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary lfades/next.js examples/remove-with-cookie-auth Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.78 kB 6.78 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary lfades/next.js examples/remove-with-cookie-auth Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary lfades/next.js examples/remove-with-cookie-auth Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary lfades/next.js examples/remove-with-cookie-auth Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary lfades/next.js examples/remove-with-cookie-auth Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary lfades/next.js examples/remove-with-cookie-auth Change
index.html gzip 927 B 927 B ✓
link.html gzip 935 B 935 B ✓
withRouter.html gzip 922 B 922 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode
General
zeit/next.js canary lfades/next.js examples/remove-with-cookie-auth Change
buildDuration 11.8s 12s ⚠️ +159ms
nodeModulesSize 55.5 MB 55.5 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary lfades/next.js examples/remove-with-cookie-auth Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..a4ac.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary lfades/next.js examples/remove-with-cookie-auth Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.78 kB 6.78 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary lfades/next.js examples/remove-with-cookie-auth Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary lfades/next.js examples/remove-with-cookie-auth Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary lfades/next.js examples/remove-with-cookie-auth Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary lfades/next.js examples/remove-with-cookie-auth Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary lfades/next.js examples/remove-with-cookie-auth Change
_error.js 557 kB 557 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 557 kB 557 kB ✓
link.js 593 kB 593 kB ✓
routerDirect.js 586 kB 586 kB ✓
withRouter.js 586 kB 586 kB ✓
Overall change 2.89 MB 2.89 MB ✓

@timneutkens timneutkens merged commit 4094dfe into vercel:canary Apr 14, 2020
@timneutkens
Copy link
Member

Checked out the passport example, looks much better than the with-cookie-auth we had before.

@vvo
Copy link
Member

vvo commented Apr 14, 2020

Also https://github.com/zeit/next.js/tree/canary/examples/with-iron-session which brings Rails-like sessions to Next.js:

  • HTTP only
  • secure
  • samesite: lax
  • signed and encrypted
  • stateless (session data stored on the client)

:p

@lfades lfades mentioned this pull request Apr 14, 2020
Closed
@lfades
Copy link
Member Author

lfades commented Apr 14, 2020 •
edited
Loading

@vvo I forgot about that one!, feel welcome to create a PR adding it to the list.

@lfades lfades mentioned this pull request Apr 14, 2020
Closed
vvo added a commit to vvo/next.js that referenced this pull request Apr 15, 2020
@vvo
docs(auth): add with-iron-session to the alternatives list
8ee3758 
Following vercel#11865 (comment)
@vvo vvo mentioned this pull request Apr 15, 2020
Merged
Timer pushed a commit that referenced this pull request Apr 15, 2020
@vvo
docs(auth): add with-iron-session to the alternatives list (#11903)
90ffdcc 
Following #11865 (comment)
This was referenced Apr 17, 2020
Merged
Merged
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lfades @ijjk @timneutkens @vvo